amaliujia commented on a change in pull request #2437:
URL: https://github.com/apache/calcite/pull/2437#discussion_r652155336
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/AggregateUnionTransposeRule.java
##########
@@ -125,30 +125,34 @@ public AggregateUnionTransposeRule(Class<? extends
Aggregate> aggregateClass,
return;
}
- // create corresponding aggregates on top of each union child
- final RelBuilder relBuilder = call.builder();
- int transformCount = 0;
+ boolean hasNonUniqueInputs = false;
final RelMetadataQuery mq = call.getMetadataQuery();
for (RelNode input : union.getInputs()) {
boolean alreadyUnique =
RelMdUtil.areColumnsDefinitelyUnique(mq, input,
aggRel.getGroupSet());
- relBuilder.push(input);
if (!alreadyUnique) {
- ++transformCount;
- relBuilder.aggregate(relBuilder.groupKey(aggRel.getGroupSet()),
- aggRel.getAggCallList());
+ hasNonUniqueInputs = true;
+ break;
}
}
- if (transformCount == 0) {
+ if (!hasNonUniqueInputs) {
Review comment:
Ack. Thanks for the clarification.
However, I am thinking at least rename this to `UniqueKeysInAllInputs` or
something like this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
