vlsi commented on a change in pull request #2441:
URL: https://github.com/apache/calcite/pull/2441#discussion_r655238744



##########
File path: core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcTable.java
##########
@@ -91,6 +94,7 @@
     this.jdbcSchemaName = jdbcSchemaName;
     this.jdbcTableName = requireNonNull(jdbcTableName, "jdbcTableName");
     this.jdbcTableType = requireNonNull(jdbcTableType, "jdbcTableType");
+    this.protoRowTypeSupplier = Suppliers.memoize(this::supplyProto);

Review comment:
       Frankly speaking, I would prefer to have it right at the field 
declaration.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to