NobiGo commented on a change in pull request #2447:
URL: https://github.com/apache/calcite/pull/2447#discussion_r662699463
##########
File path:
core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java
##########
@@ -7603,6 +7603,39 @@ void checkArrayConcatAggFuncFails(SqlTester t) {
tester.checkAgg("intersection(x)", values3, "[0, 1, 1]", 0);
}
+ @Test void testModeFunc() {
+ tester.setFor(SqlStdOperatorTable.MODE, VM_EXPAND);
+ tester.checkFails(
+ "mode(^*^)", "Unknown identifier '\\*'", false);
+ strictTester.checkFails(
+ "^mode()^",
+ "Invalid number of arguments to function 'MODE'. Was expecting 1
arguments",
Review comment:
Yes. First thanks for your review. You can find related info
[CALCITE-4661](https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-4661).
The MODE function in calcite doesn't the same as PostgreSQL, Just a normal agg
function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
