vlsi commented on a change in pull request #147:
URL: https://github.com/apache/calcite-avatica/pull/147#discussion_r662866356
##########
File path:
server/src/test/java/org/apache/calcite/avatica/server/BasicAuthHttpServerTest.java
##########
@@ -44,8 +44,8 @@
private static String url;
@BeforeClass public static void startServer() throws Exception {
- final String userPropertiesFile =
URLDecoder.decode(BasicAuthHttpServerTest.class
- .getResource("/auth-users.properties").getFile(), "UTF-8");
+ final String userPropertiesFile = (new File(BasicAuthHttpServerTest.class
+ .getResource("/auth-users.properties").toURI())).getPath();
Review comment:
Oh, I missed it is `avatica`.
I think it makes sense to copy the class or something like that.
I do remember there is a lot of edge cases near File vs URL vs URI, so I
would like to have a single class for conversion between URL and Files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
