thomasrebele commented on pull request #2486: URL: https://github.com/apache/calcite/pull/2486#issuecomment-899409149
Thank you for the pull request. I fixed the errors reported by CheckerFramework and ErrorProne in my fork. See thomasrebele/calcite/tree/CALCITE-4737. Generally it looks good. The attributes setLabels and setOriginalRel are the same for all steps. In the json file I would move them to the root level (after allNodes). I'll also add some minor review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
