yingyuwang commented on a change in pull request #2502:
URL: https://github.com/apache/calcite/pull/2502#discussion_r693074381
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/ReduceExpressionsRule.java
##########
@@ -1173,6 +1180,14 @@ private void analyzeCall(RexCall call, Constancy
callConstancy) {
/** Sets {@link #matchNullability()}. */
Config withMatchNullability(boolean matchNullability);
+ /** Whether to treat dynamic functions as non-constants. */
+ @ImmutableBeans.Property
+ @ImmutableBeans.BooleanDefault(true)
+ boolean treatDynamicCallsAsNonConstant();
Review comment:
Agreed. I prefer not using negative naming too. I've renamed it to
`treatDynamicCallsAsConstants` as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
