liyafan82 commented on a change in pull request #2501:
URL: https://github.com/apache/calcite/pull/2501#discussion_r703980337



##########
File path: 
core/src/test/java/org/apache/calcite/util/graph/DirectedGraphTest.java
##########
@@ -155,6 +155,9 @@
     final DefaultDirectedGraph<String, DefaultEdge> graph = createDag();

Review comment:
       Please also verify the (number of) edges before calling 
`removeAllVertices`, so we can be sure that the edges are actually removed. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to