asolimando commented on a change in pull request #2529:
URL: https://github.com/apache/calcite/pull/2529#discussion_r711752999
##########
File path:
core/src/test/java/org/apache/calcite/test/MaterializedViewSubstitutionVisitorTest.java
##########
@@ -1607,6 +1607,66 @@ private void checkSatisfiable(RexNode e, String s) {
+ "EnumerableTableScan(table=[[hr, MV0]])")).ok();
}
+ @Test void testGroupSetLiteral1() {
Review comment:
Maybe the test name can hint towards the specific SQL query that is
tested.
For instance, here you simply have a constant followed by a column name, the
test name could be `testGroupSetLiteralBeforeColumnName`, test
`testGroupSetLiteral2` could be `testGroupSetMultipleLiteralsBeforeColumnName`,
etc.
In this way, whenever a test failure occurs, already the name of the test
provides a hint towards which functionality was broken.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
