zabetak commented on a change in pull request #2385:
URL: https://github.com/apache/calcite/pull/2385#discussion_r712126327
##########
File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml
##########
@@ -3329,14 +3329,13 @@ LogicalProject(EMPNO=[$0], DEPTNO=[$7])
<![CDATA[
LogicalProject(EMPNO=[$0])
LogicalProject(EMPNO=[$0], ENAME=[$1], JOB=[$2], MGR=[$3], HIREDATE=[$4],
SAL=[$5], COMM=[$6], DEPTNO=[$7], SLACKER=[$8], DEPTNO0=[$9], NAME=[$10])
- LogicalJoin(condition=[true], joinType=[left])
+ LogicalCorrelate(correlation=[$cor0], joinType=[left],
requiredColumns=[{0}])
LogicalTableScan(table=[[CATALOG, SALES, EMP]])
- LogicalJoin(condition=[AND(=($0, $11), =($9, $12))], joinType=[inner])
+ LogicalJoin(condition=[AND(=($cor0.EMPNO, $2), =($0, $3))],
joinType=[inner])
LogicalTableScan(table=[[CATALOG, SALES, DEPT]])
- LogicalAggregate(group=[{0, 1}])
Review comment:
What happens if `select empno, deptno from sales.emp where empno < 20`
returns duplicates? In the current example it might not be possible since
`empno` looks like a primary key (not sure if it is declared like that in this
example).
I assume the presence of the `LogicalAggregate(group=[{0, 1}])` was to
ensure that no duplicate rows are generated. Is it normal that it is not there
anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
