zabetak commented on a change in pull request #2094:
URL: https://github.com/apache/calcite/pull/2094#discussion_r712232285
##########
File path:
core/src/main/java/org/apache/calcite/plan/RelOptMaterializations.java
##########
@@ -60,7 +66,8 @@
* materialized views used in the transformation.
*/
public static List<Pair<RelNode, List<RelOptMaterialization>>>
useMaterializedViews(
- final RelNode rel, List<RelOptMaterialization> materializations) {
+ final RelNode rel, List<RelOptMaterialization> materializations,
+ List<SubstitutionVisitor.UnifyRule> materializationRules) {
Review comment:
There is no javadoc for the new parameter.
##########
File path: core/src/main/java/org/apache/calcite/plan/AbstractRelOptPlanner.java
##########
@@ -202,6 +204,11 @@ public boolean isRuleExcluded(RelOptRule rule) {
return this;
}
+ @Experimental
Review comment:
I think we have switched to using apiguardian for this kind of
annoations.
`@API(since = "1.28", status = API.Status.EXPERIMENTAL)`
Moreover, I think the annotation should be placed in the interface
(`RelOptPlanner`) and not in the implementation class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
