julianhyde commented on pull request #2531: URL: https://github.com/apache/calcite/pull/2531#issuecomment-925135979
As @jacques-n said, this is a minimal change - in fact it's just a proof-of-concept. The real change is going to affect hundreds of files, and dozens of lines in each, because there are 142 sub-classes of RelRule.Config. And these configs are public APIs. Removing the `as` method is a net positive. Removing the `with` methods is a massive negative because of the disruption to dependent projects. Does `Immutables` have a mode where it generates copy-on-write beans (with `with` methods) as opposed to builders? That's the crux of the problem here. Is there anything in `Immutables` that converts a bean into a builder (with the same property values)? That will be necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
