jacques-n commented on a change in pull request #2531:
URL: https://github.com/apache/calcite/pull/2531#discussion_r717126725
##########
File path: core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java
##########
@@ -242,64 +245,72 @@ public static ConfigBuilder configBuilder(Config config) {
/**
* Interface to define the configuration for a SQL parser.
*/
+ @Value.Immutable(singleton = true)
+ @Value.Style(typeImmutable = "ImmutableSqlParserConfig")
public interface Config {
/** Default configuration. */
- Config DEFAULT = ImmutableBeans.create(Config.class)
- .withLex(Lex.ORACLE)
- .withIdentifierMaxLength(DEFAULT_IDENTIFIER_MAX_LENGTH)
- .withConformance(SqlConformanceEnum.DEFAULT)
- .withParserFactory(SqlParserImpl.FACTORY);
-
- @ImmutableBeans.Property()
- @ImmutableBeans.IntDefault(DEFAULT_IDENTIFIER_MAX_LENGTH)
- int identifierMaxLength();
+ Config DEFAULT = ImmutableSqlParserConfig.of();
+ @Value.Default default int identifierMaxLength() {
+ return DEFAULT_IDENTIFIER_MAX_LENGTH;
+ }
+ //Quoting.DOUBLE_QUOTE, Casing.TO_UPPER, Casing.UNCHANGED, true,
+ // CharLiteralStyle.STANDARD
Review comment:
Good catch. That was a dev note that should have been deleted. Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
