vlsi commented on a change in pull request #2531:
URL: https://github.com/apache/calcite/pull/2531#discussion_r720180924
##########
File path: core/build.gradle.kts
##########
@@ -187,6 +191,40 @@ ide {
generatedSource(javaCCTest, "test")
}
+fun JavaCompile.configureAnnotationSet(sourceSet: SourceSet) {
+ source = sourceSet.java
+ classpath = sourceSet.compileClasspath
+ destinationDirectory.set(options.generatedSourceOutputDirectory)
+ options.compilerArgs.add("-proc:only")
+
org.gradle.api.plugins.internal.JvmPluginsHelper.configureAnnotationProcessorPath(sourceSet,
sourceSet.java, options, project)
+ // only if we aren't running compileJava, since doing twice fails.
+ onlyIf {
project.gradle.taskGraph.hasTask(sourceSet.getCompileTaskName("java")) }
Review comment:
I belive `hasTask` condition should be reversed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
