zabetak commented on pull request #2449: URL: https://github.com/apache/calcite/pull/2449#issuecomment-939881009
@birschick-bq when the method argument does not have an explicit annotation then CheckerFramework uses a default based on some [rules||https://checkerframework.org/manual/#climb-to-top] and in the case of `getDefaultCompilerFactory` it is `@NonNull`. Moverover looking into the source code of `getDefaultCompilerFactory` it seems that if `null` is given as an input it will fail with NPE. Regarding the `setParentClassLoader` method the `@Nullable` annotations used by Janino are not the same used with those used by the CheckerFramework. To align them we make use of `.astub` files. I resolved the problems in commit https://github.com/apache/calcite/pull/2449/commits/a0ef603257c274d445a0c1b117db8b1eb595ca5a. Please have a look and let me know what you think. If all is good I will rebase and commit afterwards. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
