rubenada commented on a change in pull request #2581:
URL: https://github.com/apache/calcite/pull/2581#discussion_r727997677
##########
File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java
##########
@@ -189,13 +189,14 @@
private static boolean skipItem(RexNode expr) {
return expr instanceof RexCall
- && "item".equalsIgnoreCase(((RexCall) expr).getOperator().getName());
+ && "item".equalsIgnoreCase(((RexCall) expr).getOperator().getName());
Review comment:
minor: this seems an unnecessary format change
##########
File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java
##########
@@ -189,13 +189,14 @@
private static boolean skipItem(RexNode expr) {
return expr instanceof RexCall
- && "item".equalsIgnoreCase(((RexCall) expr).getOperator().getName());
+ && "item".equalsIgnoreCase(((RexCall) expr).getOperator().getName());
}
protected DiffRepository getDiffRepos() {
return DiffRepository.lookup(RelOptRulesTest.class);
}
+
Review comment:
minor: this seems an unnecessary format change
##########
File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java
##########
@@ -3234,6 +3235,20 @@ private void checkEmptyJoin(RelOptTestBase.Sql sql) {
.check();
}
+ @Test void testAgregateWithDynamicParam() {
Review comment:
Perhaps we could add here the traditional:
```
/** Test case for
* <a
href="https://issues.apache.org/jira/browse/CALCITE-4848";>[CALCITE-4848]
* Adding a HAVING condition to a query with a dynamic parameter makes the
result always empty
</a>. */
```
##########
File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml
##########
@@ -2637,6 +2653,25 @@ LogicalAggregate(group=[{0}], EXPR$1=[SUM($3)],
EXPR$2=[MIN($4)], EXPR$3=[COUNT(
LogicalAggregate(group=[{0, 1, 2}], EXPR$1=[SUM($1)], EXPR$2=[MIN($1)])
LogicalProject(DEPTNO=[$7], COMM=[$6], SAL=[$5])
LogicalTableScan(table=[[CATALOG, SALES, EMP]])
+]]>
+ </Resource>
+ </TestCase>
+ <TestCase name="testDynParamAndHaving">
Review comment:
This XML test does not seem to have its corresponding Java test, is it a
mistake?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
