jacques-n commented on pull request #2572: URL: https://github.com/apache/calcite/pull/2572#issuecomment-949829918
If I understand @julianhyde 's comment correctly in the jira, the weirdness here is that you're saying this is a numeric but then numeric (a non-declared scale/precision decimal) doesn't exist in Calcite. If this is getting coerced into a decimal type (with declared scale/precision), it isn't clear to me how this is happening and where you test cases check for this. Unless I'm misunderstanding, it seems like you either need to: - annotate the header with a specific scale/precision in the csv (e.g. `DECIMAL(30,2)`) - choose a standard scale/precision irrespective of the data and truncate or throw when the data is outside that range. - pre-scan all the values to come up with a sufficient scale/precision to support the values in the csv you are reading. Right now, it isn't clear to me what specifically is happening (and I'm not following how your test cases would clarify it). That being said, I haven't gone back and reviewed the intricacies of Calcite and SQL Decimals so I may be missing something... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
