asolimando commented on a change in pull request #2592:
URL: https://github.com/apache/calcite/pull/2592#discussion_r735818904
##########
File path: gradle.properties
##########
@@ -76,9 +76,9 @@ aggdesigner-algorithm.version=6.0
apiguardian-api.version=1.1.0
asm.version=7.2
bouncycastle.version=1.60
-cassandra-all.version=3.11.2
-cassandra-driver-core.version=3.6.0
-cassandra-unit.version=3.5.0.1
+cassandra-all.version=4.0.1
+java-driver-core.version=4.13.0
Review comment:
I totally agree, unfortunately it's artifactId of the driver itself
which changed, and since we use the artifactId to infer the `.version` property
(see
[build.gradle.kts#L21](https://github.com/apache/calcite/blob/87f60d2519dbb636d34687cbea5194ce0e8ef540/bom/build.gradle.kts#L21)),
we either:
1. leave it as is (a comment must be added, but I would not move it from
there even if it break the alphabetical ordering, because I like cassandra
variables to stay co-located), or
2. we go down some slippery path like changing the gradle code to something
like this:
```kotlin
val String.v: String get() =
(if (this == "java-driver-core")
rootProject.extra["cassandra-$this.version"]
else
rootProject.extra["$this.version"]) as String
```
I'd go with option 1. but I am open to suggestions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
