jamesstarr commented on a change in pull request #2378: URL: https://github.com/apache/calcite/pull/2378#discussion_r739619273
########## File path: core/src/main/java/org/apache/calcite/rel/metadata/MetadataHandlerProvider.java ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.rel.metadata; + +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.util.ControlFlowException; + +/** + * Provides {@link MetadataHandler} call sites and {@link MetadataCache} for + * {@link RelMetadataQuery}. The handlers provided are responsible for + * updating the cache stored in {@link RelMetadataQuery}. + */ +public interface MetadataHandlerProvider { Review comment: I have deprecated JaninoRelMetadataProvider and moved all the logic to RelMetadataHandlerGeneratorUtil. I was actually think that the name should be broader so that anything could be injected would be passed through this interface oppose to be more explicit. Maybe this should be a config object? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
