[GitHub] [calcite-avatica] vlsi commented on a change in pull request #161: [CALCITE-4877] Make the exception information more explicit for instantiate plugin.

[GitBox]

vlsi commented on a change in pull request #161:
URL: https://github.com/apache/calcite-avatica/pull/161#discussion_r744097540



##########
File path: core/src/main/java/org/apache/calcite/avatica/AvaticaUtils.java
##########
@@ -235,10 +232,29 @@ public static Class box(Class clazz) {
       } catch (NoSuchFieldException e) {
         // ignore
       }
+      assert pluginClass.isAssignableFrom(clazz);

Review comment:
       Assertions are not enabled by default. Would you please replace the 
assertion with a regular if check?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org