wnob commented on a change in pull request #2595:
URL: https://github.com/apache/calcite/pull/2595#discussion_r754893129
##########
File path: core/src/main/java/org/apache/calcite/sql/type/BasicSqlType.java
##########
@@ -54,7 +54,11 @@
* @param typeName Type name
*/
public BasicSqlType(RelDataTypeSystem typeSystem, SqlTypeName typeName) {
- this(typeSystem, typeName, false, PRECISION_NOT_SPECIFIED,
Review comment:
I'm not 100% up to speed on the theoretical ramifications of this, but
`BasicSqlType.createWithNullability` is already a thing (and it's existing
usage in Calcite is essentially the motivation for this PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
