zinking commented on a change in pull request #2616:
URL: https://github.com/apache/calcite/pull/2616#discussion_r756532281
##########
File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java
##########
@@ -1744,7 +1744,7 @@ public static boolean isValidDecimalValue(@Nullable
BigDecimal value, RelDataTyp
case DECIMAL:
final int intDigits = value.precision() - value.scale();
final int maxIntDigits = toType.getPrecision() - toType.getScale();
- return intDigits <= maxIntDigits;
+ return intDigits <= maxIntDigits && value.scale() == toType.getScale();
Review comment:
this might be the culpit of the change, I would see this as an obivious
change of the original intention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
