zabetak commented on a change in pull request #2623:
URL: https://github.com/apache/calcite/pull/2623#discussion_r761869188
##########
File path: core/src/main/java/org/apache/calcite/rel/logical/LogicalProject.java
##########
@@ -35,52 +37,63 @@
import org.apache.calcite.util.Util;
import com.google.common.collect.ImmutableList;
+import com.google.common.collect.ImmutableSet;
import org.checkerframework.checker.nullness.qual.Nullable;
import java.util.List;
+import java.util.Objects;
+import java.util.Set;
/**
* Sub-class of {@link org.apache.calcite.rel.core.Project} not
* targeted at any particular engine or calling convention.
*/
public final class LogicalProject extends Project {
+ private final ImmutableSet<CorrelationId> variablesSet;
Review comment:
I think it makes more sense to put `variablesSet` in the superclass
(`Project`) rather than here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
