vlsi commented on a change in pull request #2614:
URL: https://github.com/apache/calcite/pull/2614#discussion_r763114575
##########
File path: core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java
##########
@@ -387,6 +394,12 @@ private Object toJson(RelDataType node) {
if (node.getComponentType() != null) {
map.put("component", toJson(node.getComponentType()));
}
+ if (node.getKeyType() != null) {
+ map.put("key", toJson(requireNonNull(node.getKeyType(), "key type")));
+ }
+ if (node.getValueType() != null) {
+ map.put("value", toJson(requireNonNull(node.getValueType(), "value
type")));
+ }
Review comment:
`requireNonNull` would not be required if you save `getKeyType()` result
to a variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
