asolimando commented on pull request #2628: URL: https://github.com/apache/calcite/pull/2628#issuecomment-988163695
> * We want people to not squash/amend commits, to make them easier to review the deltas. Therefore the contributor can't change the commit message I agree on that when the review is on-going, but I have always done my squashing once all the active reviewers mark the PR "approved", just to spare some pain to the reviewers/committers (but also to have a final chance to write an extended commit message if the PR is a bit complex, definitely this is not the case). Does it pose problems too or you were referring to pending reviews? > * Some committers forget to look at JIRA comments before merging (and squashing and rebasing) the PR Probably I should have updated the PR title to reflect the new JIRA title. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
