vlsi commented on a change in pull request #2627:
URL: https://github.com/apache/calcite/pull/2627#discussion_r766332226
##########
File path: core/src/main/java/org/apache/calcite/rel/RelDistributions.java
##########
@@ -103,7 +103,7 @@ private RelDistributionImpl(Type type, ImmutableIntList
keys) {
|| Ordering.natural().isOrdered(keys)
: "key columns of hash distribution must be in order";
assert type == Type.HASH_DISTRIBUTED
- || type == Type.RANDOM_DISTRIBUTED
+ || type == Type.RANGE_DISTRIBUTED
|| keys.isEmpty();
}
Review comment:
I would say a test case is more important than JIRA.
If the assertion is user-facing, then it should be a regular if +
illegalargumentexception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
