whuGuo commented on a change in pull request #2611:
URL: https://github.com/apache/calcite/pull/2611#discussion_r770474286
##########
File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java
##########
@@ -1087,13 +1087,21 @@ private void replaceSubQueries(
final Blackboard bb,
final SqlNode expr,
RelOptUtil.Logic logic) {
+ replaceSubQueries(bb, expr, logic, false);
+ }
+
+ private void replaceSubQueries(
+ final Blackboard bb,
+ final SqlNode expr,
+ RelOptUtil.Logic logic,
+ boolean isSubQueriesOnFilter) {
findSubQueries(bb, expr, logic, false);
for (SubQuery node : bb.subQueryList) {
- substituteSubQuery(bb, node);
+ substituteSubQuery(bb, node, true);
Review comment:
done, sorry
##########
File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java
##########
@@ -1087,13 +1087,21 @@ private void replaceSubQueries(
final Blackboard bb,
final SqlNode expr,
RelOptUtil.Logic logic) {
+ replaceSubQueries(bb, expr, logic, false);
+ }
+
+ private void replaceSubQueries(
+ final Blackboard bb,
+ final SqlNode expr,
+ RelOptUtil.Logic logic,
+ boolean isSubQueriesOnFilter) {
findSubQueries(bb, expr, logic, false);
for (SubQuery node : bb.subQueryList) {
- substituteSubQuery(bb, node);
+ substituteSubQuery(bb, node, true);
Review comment:
done, sorry
##########
File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java
##########
@@ -1087,13 +1087,21 @@ private void replaceSubQueries(
final Blackboard bb,
final SqlNode expr,
RelOptUtil.Logic logic) {
+ replaceSubQueries(bb, expr, logic, false);
+ }
+
+ private void replaceSubQueries(
+ final Blackboard bb,
+ final SqlNode expr,
+ RelOptUtil.Logic logic,
+ boolean isSubQueriesOnFilter) {
findSubQueries(bb, expr, logic, false);
for (SubQuery node : bb.subQueryList) {
- substituteSubQuery(bb, node);
+ substituteSubQuery(bb, node, true);
Review comment:
done, sorry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
