zabetak commented on a change in pull request #2646:
URL: https://github.com/apache/calcite/pull/2646#discussion_r774665101



##########
File path: 
core/src/main/java/org/apache/calcite/rel/rules/ProjectCalcMergeRule.java
##########
@@ -82,8 +82,6 @@ public ProjectCalcMergeRule(RelBuilderFactory 
relBuilderFactory) {
             project.getRowType(),
             cluster.getRexBuilder());
     if (RexOver.containsOver(program)) {
-      LogicalCalc projectAsCalc = LogicalCalc.create(calc, program);

Review comment:
       This is a small breaking change. I doubt people will notice but let's 
put a small note in `history.md` to be on the safe side. Moreover, please 
remove the now obsolete comments in lines 73-75 above.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to