zabetak commented on a change in pull request #2659:
URL: https://github.com/apache/calcite/pull/2659#discussion_r775063037
##########
File path:
elasticsearch/src/test/java/org/apache/calcite/adapter/elasticsearch/ElasticSearchAdapterTest.java
##########
@@ -462,6 +462,14 @@ public static void setupInstance() throws Exception {
.explainContains(explain);
}
+ /**
+ * Range query is not supported currently.
+ * @see <a
href="https://issues.apache.org/jira/browse/CALCITE-4645";>[CALCITE-4645]
+ * In Elasticsearch adapter, a range predicate should be translated to a
range query</a>
+ * <p>Description about translating search call to range query
+ * {@link
org.apache.calcite.adapter.elasticsearch.PredicateAnalyzer.Visitor#canBeTranslatedToTermsQuery(RexCall)}
+ */
+ @Disabled
Review comment:
I think it is better to create an entry in
https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/util/Bug.java
class and use that value to skip/disable the test.
##########
File path:
elasticsearch/src/test/java/org/apache/calcite/adapter/elasticsearch/BooleanLogicTest.java
##########
@@ -120,7 +118,6 @@ public static void setupInstance() throws Exception {
assertEmpty("select * from view where num > 42 and num < 42 and num = 42");
assertEmpty("select * from view where num > 42 or num < 42 and num = 42");
assertSingle("select * from view where num > 42 and num < 42 or num = 42");
- assertSingle("select * from view where num > 42 or num < 42 or num = 42");
Review comment:
Instead of removing completely the test can you please skip the line
using a (new) reference from
https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/util/Bug.java.
##########
File path:
elasticsearch/src/test/java/org/apache/calcite/adapter/elasticsearch/EmbeddedElasticsearchPolicy.java
##########
@@ -197,7 +197,11 @@ RestClient restClient() {
return client;
}
- final RestClient client = RestClient.builder(httpHost()).build();
+ final RestClient client = RestClient.builder(httpHost())
+ .setRequestConfigCallback(requestConfigBuilder -> requestConfigBuilder
+ .setConnectTimeout(60 * 1000) // default 1000
+ .setSocketTimeout(3 * 60 * 1000)) // default 30000
+ .build();
Review comment:
How did you choose the new values? Did you do any tests?
##########
File path:
elasticsearch/src/test/java/org/apache/calcite/adapter/elasticsearch/ElasticSearchAdapterTest.java
##########
@@ -476,8 +484,8 @@ public static void setupInstance() throws Exception {
@Test void testInPlan() {
final String[] searches = {
- "query: {'constant_score':{filter:{bool:{should:"
Review comment:
Why did `bool:should` disappeared?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
