danny0405 commented on a change in pull request #2664:
URL: https://github.com/apache/calcite/pull/2664#discussion_r777164438
##########
File path: core/src/main/java/org/apache/calcite/rel/core/RelFactories.java
##########
@@ -392,29 +392,39 @@ RelNode createJoin(RelNode left, RelNode right,
List<RelHint> hints,
* <p>The result is typically a {@link Correlate}.
*/
public interface CorrelateFactory {
+
/**
* Creates a correlate.
*
* @param left Left input
* @param right Right input
+ * @param hints Hints
* @param correlationId Variable name for the row of left input
* @param requiredColumns Required columns
* @param joinType Join type
*/
- RelNode createCorrelate(RelNode left, RelNode right,
+ RelNode createCorrelate(RelNode left, RelNode right, List<RelHint> hints,
CorrelationId correlationId, ImmutableBitSet requiredColumns,
JoinRelType joinType);
+
+ @Deprecated // to be removed before 1.23
+ default RelNode createCorrelate(RelNode left, RelNode right,
+ CorrelationId correlationId, ImmutableBitSet requiredColumns,
Review comment:
No need to add this default impl, `createCorrelate` is kind of internal
API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
