xuzifu666 edited a comment on pull request #2688: URL: https://github.com/apache/calcite/pull/2688#issuecomment-1011178544
> CI/CD won't necessarily break if you remove them, they might be unused _within_ Calcite, but they can be very well used by Calcite users, removing them might break their code. > > What others suggested, going through a `@Deprecated` annotation is what we generally do. > > However, it would be good to at least comment on why some methods are deprecated, and what to use instead in order to achieve the same goal, if possible (e.g., multiple versions of a constructor for a given class). ok, these methods can be used by normal non agrs constructor to build, do not need to provided with a specified method，according to design patterns the way of providing a method which is not used in project internally is not perfect.add a deprecated annotation to remind user not use these method is a way to improve Calcite code in next versions. the case also in other project, they use the same way to remind users about it. @asolimando @rubenada -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
