NobiGo commented on a change in pull request #2692:
URL: https://github.com/apache/calcite/pull/2692#discussion_r785598915
##########
File path: babel/src/test/java/org/apache/calcite/test/BabelParserTest.java
##########
@@ -261,6 +261,15 @@ private void checkParseInfixCast(String sqlType) {
sql(sql).ok(expected);
}
+ /** Tests parsing MySQL-style "<=>" equal operator. */
+ @Test void testParseNullSafeEqual() {
+ String sql = "SELECT x <=> 3 FROM (VALUES (1, 2)) as tbl(x,y)";
+ String expected = ""
Review comment:
Please reformat the SQL.
##########
File path:
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java
##########
@@ -706,4 +707,17 @@ private SqlLibraryOperators() {
@LibraryOperator(libraries = { POSTGRESQL })
public static final SqlOperator INFIX_CAST =
new SqlCastOperator();
+
+ /** Null-safe "<=>" equal operator used by MySQL, for example
+ * {@code 1<=>NULL}. */
+ @LibraryOperator(libraries = { MYSQL })
+ public static final SqlOperator NULL_SAFE_EQUAL =
Review comment:
I think The NULL_SAFE_EQUAL **is** IS_NOT_DISTINCT_FROM. Not belong to.
So
```
public static final SqlOperator NULL_SAFE_EQUAL =
SqlStdOperatorTable.IS_NOT_DISTINCT_FROM;
```
right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
