jaystarshot commented on a change in pull request #2710:
URL: https://github.com/apache/calcite/pull/2710#discussion_r799167054
##########
File path: core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java
##########
@@ -1179,7 +1179,9 @@ private SqlCall toSql(SqlOperator op, boolean distinct,
// Handle filter by generating FILTER (WHERE ...)
final SqlCall call2;
- if (filterArg < 0) {
Review comment:
Why cannot we just check if `op instanceof
SqlOperatorTable.APPROX_COUNT_DISTINCT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
