NobiGo commented on a change in pull request #2721:
URL: https://github.com/apache/calcite/pull/2721#discussion_r808728153
##########
File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
##########
@@ -204,8 +204,8 @@ public RexNode simplifyPreservingType(RexNode e,
RexUnknownAs unknownAs,
*
* <p>In particular:</p>
* <ul>
- * <li>{@code simplify(x = 1 AND y = 2 AND NOT x = 1)}
Review comment:
No. What the expression should be returned is decided by how we treat
the UNKNOW. For example:
```
x=1 AND NOT x=1
If UNKNOW as FALSE then return FALSE;
If UNKNOW as TRUE then return FALSE;
If UNKNOW as UNKNOW then return UNKNOW.(Then (x = 1 AND y = 2 AND NOT x = 1)
result will not be a definite value)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
