IceMimosa commented on a change in pull request #2729:
URL: https://github.com/apache/calcite/pull/2729#discussion_r813527856
##########
File path: core/src/test/java/org/apache/calcite/test/ScannableTableTest.java
##########
@@ -155,7 +155,7 @@
"j=Paul");
// Only 2 rows came out of the table. If the value is 4, it means that the
// planner did not pass the filter down.
- assertThat(buf.toString(), is("returnCount=2, filter=<0, 4>,
projects=[1]"));
+ assertThat(buf.toString(), is("returnCount=2, filter=<0, 4>, projects=[1,
0]"));
Review comment:
@JiajunBernoulli This test wants to pushdown filter to table scan, but
it's not suitable here, it should use RelRule to do this in optimize phase.
`TableScan's projects` and `ProjectableFilterableTable's projects` are not the
same, The test here is `select j where i`, in physical execution, the
ProjectableFilterableTable's projects must contain `j` and `i` if you don't
change the AST.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
