julianhyde commented on pull request #2727: URL: https://github.com/apache/calcite/pull/2727#issuecomment-1057329792
This PR looks good. @NobiGo, Can you add one or two more comments that the problem is the CAST. The .iq tests should point out the the simplified plan has only 'deptno = 25' and has dropped the 'deptno <> 20' condition. When I am squashing these commits I'll probably use 'Expressions with numeric comparisons are not simplified when CAST is present' as the commit message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
