zabetak commented on a change in pull request #2744:
URL: https://github.com/apache/calcite/pull/2744#discussion_r826958766
##########
File path:
core/src/main/java/org/apache/calcite/sql/type/SqlTypeFactoryImpl.java
##########
@@ -93,7 +93,7 @@ public SqlTypeFactoryImpl(RelDataTypeSystem typeSystem) {
}
@Override public RelDataType createUnknownType() {
Review comment:
By adding `UNKNOWN` under `SqlTypeName` enum we are essentially making
it a basic SQL type so we could consider deprecating and eventually removing
the `createUnknownType` API. It's probably out of the scope of this PR but if
it makes sense we could log a followup JIRA to tackle it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
