wojustme commented on a change in pull request #2743:
URL: https://github.com/apache/calcite/pull/2743#discussion_r827573770
##########
File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java
##########
@@ -5582,8 +5603,8 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule rule)
{
@Test void testAggregateConstantKeyRule3() {
final String sql = "select job\n"
+ "from sales.emp\n"
- + "where sal is null and job = 'Clerk'\n"
- + "group by sal, job\n"
+ + "where mgr is null and job = 'Clerk'\n"
Review comment:
@NobiGo Thanks for your reply.
I wanted to submit this pr to solve
[ISSUE-5038](https://issues.apache.org/jira/browse/CALCITE-5038) together。
But, I thought about it for a while, I think I may split the changed codes
into two prs to prevent ambiguity.
Please review [PR-2742](https://github.com/apache/calcite/pull/2742) firstly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
