NobiGo commented on code in PR #2735:
URL: https://github.com/apache/calcite/pull/2735#discussion_r843675052
##########
core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java:
##########
@@ -294,6 +294,33 @@ public static boolean containsNullable(RelDataType type) {
return false;
}
+ /**
+ * Recreates a RelDataType with the type keep same as the param
sourceRelDataType and
+ * nullability keep same as the param targetRelDataType.
+ */
+ public static RelDataType keepNullableSame(RelDataType sourceRelDataType,
Review Comment:
Looks good, I will fix it.
##########
core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java:
##########
@@ -294,6 +294,33 @@ public static boolean containsNullable(RelDataType type) {
return false;
}
+ /**
+ * Recreates a RelDataType with the type keep same as the param
sourceRelDataType and
+ * nullability keep same as the param targetRelDataType.
Review Comment:
Looks good, I will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
