zabetak commented on PR #2698: URL: https://github.com/apache/calcite/pull/2698#issuecomment-1094120523
@jnturton @asereda-gs there are many points where I agree with you. It would be a good idea to bring up the general problem of closing resources to the dev list but I don't consider this a must for moving this forward. If we find a satisfactory solution without revising all adapter APIs then I could leave with it till we tackle the general problem. I wouldn't mind going forward with the Guava cache but as Andrei mentioned the cache doesn't know when to close the client. What happens if the `RestClient` that we are evicting from the cache is still in use in a schema? If this is possible then I guess we are going to create a new bug while trying to fix this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
