F21 commented on PR #60: URL: https://github.com/apache/calcite-avatica-go/pull/60#issuecomment-1114066311
Thanks for opening this PR! I don't think we need to do this though, as the connector interface already provides the ability for you to supply your own customized `http.Client`. Another reason is that I don't think it's a good idea to include all the http connection options in the DSN as there will be a very long list of configurable options. Would using the [`Connector`](https://pkg.go.dev/github.com/apache/calcite-avatica-go/[email protected]#Connector) work for your use case? You can use it like this: ````go httpClient := &http.Client{ ... } connector := avatica.Connector{ Client: httpClient, } db := sql.OpenDB(connector) err := db.Ping() ```` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
