chunweilei commented on PR #2800: URL: https://github.com/apache/calcite/pull/2800#issuecomment-1123113012
> Hi @chunweilei I think we need consider more possibilities about join-condition. An example: `select t1.deptno from emp t1 inner join emp t2 on t1.mgr IS NOT DISTINCT FROM t2.mgr` I think we needn't create new filter of `is_not_null`, because the join condition will return true(`t1.mgr is null and t2.mgr is null`) That's a good point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
