wojustme commented on PR #2800: URL: https://github.com/apache/calcite/pull/2800#issuecomment-1127155158
I looked through the code, and this pr is good for me. I try an another test case `select t1.deptno from emp t1 join emp t2 on coalesce(t1.mgr = t2.mgr, false)`, and the result of rule isn't what I want. In my opinion, this rule is OK now, because it has no side effects, although this rule doesn't work. I think `org.apache.calcite.plan.Strong` could be enhanced. LGTM for this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
