chunweilei commented on code in PR #2815:
URL: https://github.com/apache/calcite/pull/2815#discussion_r878965484
##########
core/src/main/java/org/apache/calcite/rel/RelHomogeneousShuttle.java:
##########
@@ -19,6 +19,7 @@
import org.apache.calcite.rel.core.TableFunctionScan;
import org.apache.calcite.rel.core.TableScan;
import org.apache.calcite.rel.logical.LogicalAggregate;
+import org.apache.calcite.rel.logical.LogicalCalc;
import org.apache.calcite.rel.logical.LogicalCorrelate;
Review Comment:
Tips: remove the `.` in the commit message.
##########
core/src/main/java/org/apache/calcite/rel/logical/LogicalTableModify.java:
##########
@@ -92,4 +93,8 @@ public static LogicalTableModify create(RelOptTable table,
sole(inputs), getOperation(), getUpdateColumnList(),
getSourceExpressionList(), isFlattened());
}
+
+ @Override public RelNode accept(RelShuttle shuttle) {
+ return shuttle.visit(this);
+ }
Review Comment:
Could you please check whether other operators have the same issue too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
