julianhyde commented on code in PR #2819:
URL: https://github.com/apache/calcite/pull/2819#discussion_r885021274
##########
core/src/main/codegen/templates/Parser.jj:
##########
@@ -238,6 +238,39 @@ public class ${parser.class} extends SqlAbstractParserImpl
return SqlStmtList();
}
+ // Q: Is it the best way ???
Review Comment:
To do it properly, I agree, we should pass parser factory and config in the
validator config. But for now it's probably OK to use the default parser.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
