rubenada commented on code in PR #2829:
URL: https://github.com/apache/calcite/pull/2829#discussion_r893491953
##########
core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java:
##########
@@ -1595,6 +1590,7 @@ static Map<Integer, Integer> identityMap(int count) {
Frame register(RelNode rel, RelNode newRel,
Map<Integer, Integer> oldToNewOutputs,
NavigableMap<CorDef, Integer> corDefOutputs) {
+ newRel = RelOptUtil.copyRelHints(rel, newRel);
Review Comment:
Uhm, good point. I guess it will be safer to use
`RelOptUtil.propagateRelHints` instead of `RelOptUtil#copyRelHints` to cover
also the cases that you mention.
@danny0405 IIRC you were the one that implemented the Hints mechanism, do
you agree?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
