[GitHub] [calcite] alimans3 commented on a diff in pull request #2887: [CALCITE-5247] FilterJoinRule cannot simplify left join to inner join for `WHERE RHS.C1 IS NOT NULL OR RHS.C2 IS NOT NULL`

Tue, 30 Aug 2022 11:20:12 -0700 


alimans3 commented on code in PR #2887:
URL: https://github.com/apache/calcite/pull/2887#discussion_r958796188


##########
core/src/main/java/org/apache/calcite/plan/Strong.java:
##########
@@ -151,12 +151,41 @@ public static boolean allStrong(List<RexNode> operands) {
 
   /** Returns whether an expression is definitely not true. */
   public boolean isNotTrue(RexNode node) {
+    return isPredicateNotTrue(node) || isNull(node);

Review Comment:
   it is doable, it covers more cases this way hence the new change in 
RelOptRules.xml
   The case is AND/OR(DEFINITELY FALSE, DEFINITELY NULL) -> DEFINITELY FALSE
   done!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to