[GitHub] [calcite] chunweilei commented on a diff in pull request #2891: [CALCITE-5260] Pop the last RelNode added into the bindings list when failing to apply a rule

Mon, 19 Sep 2022 18:50:36 -0700 


chunweilei commented on code in PR #2891:
URL: https://github.com/apache/calcite/pull/2891#discussion_r974815308


##########
core/src/main/java/org/apache/calcite/plan/hep/HepPlanner.java:
##########
@@ -614,7 +615,7 @@ private List<HepRelVertex> getVertexParents(HepRelVertex 
vertex) {
   private static boolean matchOperands(
       RelOptRuleOperand operand,
       RelNode rel,
-      List<RelNode> bindings,
+      Stack<RelNode> bindings,
       Map<RelNode, List<RelNode>> nodeChildren) {
     if (!operand.matches(rel)) {
       return false;

Review Comment:
   Could you add a test case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to