zabetak commented on code in PR #2911:
URL: https://github.com/apache/calcite/pull/2911#discussion_r975066157
##########
core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java:
##########
@@ -481,6 +481,18 @@ public TrimResult trimFields(
final int fieldCount = rowType.getFieldCount();
final RelNode input = project.getInput();
+ boolean containsSubQuery = false;
+ for (RexNode node : project.getProjects()) {
+ if (RexUtil.containsSubQuery(node)) {
+ containsSubQuery = true;
+ break;
+ }
+ }
+ // Do not trim Project's fields before SubQueryRemoveRule applies.
+ if (containsSubQuery) {
+ return result(project, Mappings.createIdentity(fieldCount));
+ }
+
Review Comment:
Maybe it is worth adding the new test also in `RelFieldTrimmerTest` since it
is explicitly targeting this code path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
