zabetak commented on code in PR #2915:
URL: https://github.com/apache/calcite/pull/2915#discussion_r976589860
##########
core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java:
##########
@@ -94,7 +94,7 @@ public interface Config extends RelRule.Config {
public static final RelOptRule UNION_INSTANCE =
ImmutableUnionEmptyPruneRuleConfig.of()
.withOperandSupplier(b0 ->
- b0.operand(LogicalUnion.class).unorderedInputs(b1 ->
+ b0.operand(Union.class).unorderedInputs(b1 ->
Review Comment:
Hmm, I didn't notice that the other rules were configured for the general
operators. Your initial proposal makes sense. Please revert
https://github.com/apache/calcite/pull/2915/commits/ad4cfeaf49100f0ce7f5668c0c55fc2fbd8a0a8a
and add a note in `history.md` (breaking changes section) about the slight
change in behavior in the default configuration regarding these rules.
I will merge the PR afterwards; sorry for the back n forth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
