asolimando commented on code in PR #2916:
URL: https://github.com/apache/calcite/pull/2916#discussion_r978338926
##########
core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java:
##########
@@ -479,13 +481,24 @@ public interface JoinLeftEmptyRuleConfig extends
PruneEmptyRule.Config {
@Override default PruneEmptyRule toRule() {
return new PruneEmptyRule(this) {
@Override public void onMatch(RelOptRuleCall call) {
- Join join = call.rel(0);
+ final Join join = call.rel(0);
+ final Values empty = call.rel(1);
+ final RelNode right = call.rel(2);
+ final RelBuilder b = call.builder();
Review Comment:
Nitpick: in the codebase this is generally called `relBuilder`, the method
is not big but you might wonder what `b` is in the rest of the code, while with
`relBuilder` it will be pretty clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
